Ignore asan warnings (clang) #3844
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctummon
commented
Jun 20, 2022
| @@ -1 +0,0 @@ | |||
| src:*ed25519* | |||
There was a problem hiding this comment.
I don't think this file was used, correct me if I'm wrong
ctummon
commented
Jun 20, 2022
| @@ -247,11 +247,25 @@ else() | |||
| endif() | |||
|
|
|||
| if(${USING_ASAN} OR ${USING_ASAN_INT}) | |||
|
|
|||
| if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
There was a problem hiding this comment.
-fsanitize-blacklist and -fsanitize=integer only seem to be available with Clang so I added some checks
|
OSX (RocksDB) is failing on core_test: error code '124' after "active_transactions.fork_filter_cleanup" looks like a false positive? Same error for the code of conduct PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted to test out my WSL dev environment with Visual Code so took a crack at some of the address sanitizer warnings
1.) Added function attribute to ignore false unsigned int overflow warnings which fixes:
#3658
#3659
2.) Added blacklist file for Clang Address Sanitizer.
Also when running Address Sanitizer with core_test aborts in a couple of places:
It doesn't like that network_params is a reference and it is being accessed on different threads.
Is this a known issue or should I create a new issue?